Repository navigation
Fix ogr source feature serialization performance issues - #2474
Open
reinvantveer wants to merge 1 commit into
Open
reinvantveer wants to merge 1 commit into
reinvantveer wants to merge 1 commit into
Conversation
Co-authored-by: Junie <junie@jetbrains.com> Signed-off-by: reinvantveer <rein@vantveer.me>
Contributor
|
@reinvantveer Thank you for your honest disclosure! |
Contributor
Author
|
@tomkralidis would you be OK to look into this? Or is there something inhibiting a merge of this PR in any way? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Related Issue / discussion
Resolves #2473
AI disclosure: although Claude Opus 5.5 greatly helped in determining the cause of and writing the fix for, this performance bug, I checked every step to validate parity and that it is a "pure refactor". The commits are signed by me (@reinvantveer) and co-authored by the JetBrains Junie agent.
I'm fully on board with the BHFH statement, but I'll be honest and state that I wouldn't have been able to contribute this PR if it hadn't been for AI. I did, however, ask explicitly for adding parity checks that verify that the output of the refactored code is unchanged.
NOTE that this fix is already running in production on our platform, and that I'm very happy with the results 😄
NOTE2 the failing test steps are not related to changes in this PR. These failures originate in the
zarrandxarraydependency versions.Additional information
Dependency policy (RFC2)
Updates to public demo
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)